RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4]
Magnus Ihse Bursie
ihse at openjdk.java.net
Fri Jun 10 09:53:03 UTC 2022
On Fri, 10 Jun 2022 07:18:34 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another way.
>
> .github/workflows/main.yml line 138:
>
>> 136: apt-gcc-version: '10-multilib'
>> 137: apt-architecture: ':i386'
>> 138: apt-add-architecture: 'sudo dpkg --add-architecture i386'
>
> Feels a bit weird to have the entire command line here. I'd expect to see something like `apt-add-architecture: i386`.
If I do that, there need to be some kind of if statement in the called workflow, since if that input argument is left out, we'd get a command line like `sudo dpkg --add-architecture` which I assume is illegal syntax (or, possibly worse, does something other than a no-op).
I think there can be room for additional improvement in especially the "special" linux builds, but I had to draw the line somewhere, to be able to finish this PR.
-------------
PR: https://git.openjdk.org/jdk/pull/9063
More information about the build-dev
mailing list