RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4]

Magnus Ihse Bursie ihse at openjdk.java.net
Fri Jun 10 20:20:42 UTC 2022


On Fri, 10 Jun 2022 11:23:57 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> If I do that, there need to be some kind of if statement in the called workflow, since if that input argument is left out, we'd get a command line like `sudo dpkg --add-architecture` which I assume is illegal syntax (or, possibly worse, does something other than a no-op).
>> 
>> I think there can be room for additional improvement in especially the "special" linux builds, but I had to draw the line somewhere, to be able to finish this PR.
>
> I think you can make a conditionalized step that runs in case the value is not empty, and skip the step otherwise. If that is hard, it can be done in the followup, sure.

I cleaned up the entire "apt architecture" handling a bit. Some part of the code got more complex, but overall I think it was worth it due to the higher level of abstraction.

-------------

PR: https://git.openjdk.org/jdk/pull/9063



More information about the build-dev mailing list