RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4]

[Aleksey Shipilev]

On Fri, 10 Jun 2022 09:39:29 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> .github/actions/get-bootjdk/action.yml line 26:
>> 
>>> 24: #
>>> 25: 
>>> 26: name: 'Get BootJDK'
>> 
>> Here and later, polishing: "BootJDK" -> "boot JDK"?
>
> I think we've mostly been using "BootJDK" as a specialized term in the build system, but we've not been very consistent about it: 
> 
> ihse at mercurius:~/git/jdk-ALT/open/make$ gr -i "Boot JDK" | wc
>       61     673    5606
> ihse at mercurius:~/git/jdk-ALT/open/make$ gr -i BootJDK | wc
>       79     298    5947
> 
> 
> but I can switch it out to `Boot JDK` if that makes you happier.

Nevermind then.

>> .github/workflows/main.yml line 138:
>> 
>>> 136:       apt-gcc-version: '10-multilib'
>>> 137:       apt-architecture: ':i386'
>>> 138:       apt-add-architecture: 'sudo dpkg --add-architecture i386'
>> 
>> Feels a bit weird to have the entire command line here. I'd expect to see something like `apt-add-architecture: i386`.
>
> If I do that, there need to be some kind of if statement in the called workflow, since if that input argument is left out, we'd get a command line like `sudo dpkg --add-architecture` which I assume is illegal syntax (or, possibly worse, does something other than a no-op).
> 
> I think there can be room for additional improvement in especially the "special" linux builds, but I had to draw the line somewhere, to be able to finish this PR.

I think you can make a conditionalized step that runs in case the value is not empty, and skip the step otherwise. If that is hard, it can be done in the followup, sure.

-------------

PR: https://git.openjdk.org/jdk/pull/9063