RFR: JDK-8282700: Properly handle several --without options during configure [v4]

Julian Waters jwaters at openjdk.java.net
Thu Mar 10 09:51:40 UTC 2022


On Thu, 10 Mar 2022 09:41:32 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix syntax errors
>
> make/autoconf/jdk-version.m4 line 554:
> 
>> 552:   elif test "x$with_macosx_bundle_build_version" = xno; then
>> 553:     # Interpret --without-* as empty string instead of the literal "no"
>> 554:     MACOSX_BUNDLE_BUILD_VERSION=
> 
> Same objection here. And even if it works right now, if we do allow this, it means that all future changes in the build system that involves MACOSX_BUNDLE_BUILD_VERSION needs to be verified that it works with the empty string.

>From what I can tell, wouldn't MACOSX_BUNDLE_BUILD_VERSION be an empty string anyway if both VERSION_BUILD and VERSION_OPT = ""?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7713



More information about the build-dev mailing list