RFR: JDK-8282700: Properly handle several --without options during configure [v4]

[Magnus Ihse Bursie]

On Thu, 10 Mar 2022 09:48:52 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> make/autoconf/jdk-version.m4 line 554:
>> 
>>> 552:   elif test "x$with_macosx_bundle_build_version" = xno; then
>>> 553:     # Interpret --without-* as empty string instead of the literal "no"
>>> 554:     MACOSX_BUNDLE_BUILD_VERSION=
>> 
>> Same objection here. And even if it works right now, if we do allow this, it means that all future changes in the build system that involves MACOSX_BUNDLE_BUILD_VERSION needs to be verified that it works with the empty string.
>
> From what I can tell, wouldn't MACOSX_BUNDLE_BUILD_VERSION be an empty string anyway if both VERSION_BUILD and VERSION_OPT = ""?

That might be. If that is so, then you've most likely spotted a bug. In practice, you're either building an official build and have a build number, or an adhoc build with an opt string, so I'm not suprised noone has run into this.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7713