RFR: 8283062: Uninitialized warnings in libgtest with GCC 11.2

Mikael Vidstedt mikael at openjdk.java.net
Sat Mar 12 03:32:54 UTC 2022


Background, from JBS:

In file included from googletest-release-1.8.1/googletest/src/gtest-all.cc:42: 
googletest-release-1.8.1/googletest/src/gtest-death-test.cc: In function 'bool testing::internal::StackGrowsDown()': 
googletest-release-1.8.1/googletest/src/gtest-death-test.cc:1224:24: error: 'dummy' may be used uninitialized [-Werror=maybe-uninitialized] 
 1224 | StackLowerThanAddress(&dummy, &result); 
      | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ 
googletest-release-1.8.1/googletest/src/gtest-death-test.cc:1214:13: note: by argument 1 of type 'const void*' to 'void testing::internal::StackLowerThanAddress(const void*, bool*)' declared here 
 1214 | static void StackLowerThanAddress(const void* ptr, bool* result) { 
      | ^~~~~~~~~~~~~~~~~~~~~ 
googletest-release-1.8.1/googletest/src/gtest-death-test.cc:1222:7: note: 'dummy' declared here 
 1222 | int dummy;


Details:

Since googletest is external code this change disable the relevant warning.

Testing:

tier1, builds-tier{2,3,4,5}

-------------

Commit messages:
 - 8283062: Uninitialized warnings in libgtest with GCC 11.2

Changes: https://git.openjdk.java.net/jdk/pull/7798/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7798&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8283062
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7798.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7798/head:pull/7798

PR: https://git.openjdk.java.net/jdk/pull/7798



More information about the build-dev mailing list