RFR: 8283062: Uninitialized warnings in libgtest with GCC 11.2

Jie Fu jiefu at openjdk.java.net
Sat Mar 12 03:48:38 UTC 2022


On Sat, 12 Mar 2022 03:26:29 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

> Background, from JBS:
> 
> In file included from googletest-release-1.8.1/googletest/src/gtest-all.cc:42: 
> googletest-release-1.8.1/googletest/src/gtest-death-test.cc: In function 'bool testing::internal::StackGrowsDown()': 
> googletest-release-1.8.1/googletest/src/gtest-death-test.cc:1224:24: error: 'dummy' may be used uninitialized [-Werror=maybe-uninitialized] 
>  1224 | StackLowerThanAddress(&dummy, &result); 
>       | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ 
> googletest-release-1.8.1/googletest/src/gtest-death-test.cc:1214:13: note: by argument 1 of type 'const void*' to 'void testing::internal::StackLowerThanAddress(const void*, bool*)' declared here 
>  1214 | static void StackLowerThanAddress(const void* ptr, bool* result) { 
>       | ^~~~~~~~~~~~~~~~~~~~~ 
> googletest-release-1.8.1/googletest/src/gtest-death-test.cc:1222:7: note: 'dummy' declared here 
>  1222 | int dummy;
> 
> 
> Details:
> 
> Since googletest is external code this change disable the relevant warning.
> 
> Testing:
> 
> tier1, builds-tier{2,3,4,5}

Looks reasonable to me.

-------------

Marked as reviewed by jiefu (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7798



More information about the build-dev mailing list