RFR: 8283323: libharfbuzz optimization level results in extreme build times [v2]

[Magnus Ihse Bursie]

On Wed, 23 Mar 2022 22:37:55 GMT, Phil Race <prr at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restore HIGHEST for entire lib, just set SIZE to two files
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 487:
> 
>> 485: LIBFONTMANAGER_OPTIMIZATION := HIGHEST
>> 486: 
>> 487: ifneq ($(filter $(TOOLCHAIN_TYPE), gcc clang), )
> 
> Can we have a note here that the de-opt is possible because these two files aren't important to OpenJDK ?
> If these files were to be renamed in an updated version of harfbuzz, would there be a compilation error ?

Comment updated.

No, these directives will be just silently ignored. So if that happens we run the risk of reintroducing the build performance regression. Not a big risk. In any case, at next harfbuzz update it can be worth re-checking if these exceptions are still needed. (If you're the one doing it and need help with that, just let me know!)

-------------

PR: https://git.openjdk.java.net/jdk/pull/7919