RFR: 8283323: libharfbuzz optimization level results in extreme build times [v2]

[Phil Race]

On Wed, 23 Mar 2022 23:13:04 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 487:
>> 
>>> 485: LIBFONTMANAGER_OPTIMIZATION := HIGHEST
>>> 486: 
>>> 487: ifneq ($(filter $(TOOLCHAIN_TYPE), gcc clang), )
>> 
>> Can we have a note here that the de-opt is possible because these two files aren't important to OpenJDK ?
>> If these files were to be renamed in an updated version of harfbuzz, would there be a compilation error ?
>
> Comment updated.
> 
> No, these directives will be just silently ignored. So if that happens we run the risk of reintroducing the build performance regression. Not a big risk. In any case, at next harfbuzz update it can be worth re-checking if these exceptions are still needed. (If you're the one doing it and need help with that, just let me know!)

As of today they are still there in upstream harfbuzz on github.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7919