RFR: 8295792: Clean up old async close code
Daniel Jeliński
djelinski at openjdk.org
Fri Oct 21 17:11:48 UTC 2022
On Fri, 21 Oct 2022 16:04:24 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Please review this PR that removes the remains of old fdTable-based socket close synchronization.
>>
>> Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did not verify AIX.
>>
>> Also removed one slow test for an issue in fdtable implementation; as far as I could tell, it is no longer relevant.
>
> src/java.base/unix/native/libnet/net_util_md.c line 703:
>
>> 701:
>> 702: errno = 0;
>> 703: read_rv = poll(&pfd, 1, nanoTimeout / NET_NSEC_PER_MSEC);
>
> I suspect this one will need to handle EINTR like the original code.
as far as I can tell, this method retries all poll failures regardless of errno until timeout expires; NET_Poll retried EINTR, so I think we're good here. Or am I missing something?
-------------
PR: https://git.openjdk.org/jdk/pull/10816
More information about the build-dev
mailing list