RFR: 8295792: Clean up old async close code

Alan Bateman alanb at openjdk.org
Fri Oct 21 17:15:50 UTC 2022


On Fri, 21 Oct 2022 17:08:07 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> src/java.base/unix/native/libnet/net_util_md.c line 703:
>> 
>>> 701: 
>>> 702:         errno = 0;
>>> 703:         read_rv = poll(&pfd, 1, nanoTimeout / NET_NSEC_PER_MSEC);
>> 
>> I suspect this one will need to handle EINTR like the original code.
>
> as far as I can tell, this method retries all poll failures regardless of errno until timeout expires; NET_Poll retried EINTR, so I think we're good here. Or am I missing something?

I think you are right, it's ignoring all errors so will continue to loop if interrupted.

-------------

PR: https://git.openjdk.org/jdk/pull/10816



More information about the build-dev mailing list