RFR: 8293219: Microsoft toolchain selection picks 32-bit tools over 64-bit

Aleksey Shipilev shade at openjdk.org
Thu Sep 1 19:13:09 UTC 2022


On Thu, 1 Sep 2022 15:58:35 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The logic in toolchain_windows.m4 happens to prefer the 32-bit version of the tools. This is incorrect, since we only support building on 64-bit Windows. 
> 
> Also, since dropping VS2017, we can remove some old bat files we do no longer have to look for.

Well... We actually build Windows x86 binaries (yes, 2022, I know). Mostly by "cross-compiling" from x86_64. 

But the patch does a good cleanup anyway: we should be trying the native tools before reaching for cross-compilation ones. I can test Windows x86 build with this patch.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10121



More information about the build-dev mailing list