RFR: 8293219: Microsoft toolchain selection picks 32-bit tools over 64-bit

[Magnus Ihse Bursie]

On Thu, 1 Sep 2022 15:58:35 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The logic in toolchain_windows.m4 happens to prefer the 32-bit version of the tools. This is incorrect, since we only support building on 64-bit Windows. 
> 
> Also, since dropping VS2017, we can remove some old bat files we do no longer have to look for.

I was perhaps not completely clear. We only support 64-bit Windows as *build* platform. Having 32-bit Windows as *target* is still valid (although not extensively tested). This is not really a completely native build, nor really a "cross-compilation" either in the traditional sense (since the generated binaries can be run on the build platform). We call it a "reduced" build (iirc), and you get that by the `--with-target-cpu-bits=32` flag.

But support for actually *building* on a 32-bit Windows was dropped a long time ago.

But yes, please do test to build for 32-bit Windows. I'll hold back the integration until you report that it still works okay.

-------------

PR: https://git.openjdk.org/jdk/pull/10121