RFR: 8305089: Implement missing socket options on AIX [v2]

Jaikiran Pai jpai at openjdk.org
Tue Apr 4 05:53:08 UTC 2023


On Thu, 30 Mar 2023 16:05:08 GMT, Varada M <duke at openjdk.org> wrote:

>> Breaking this into two parts : 
>> 
>> 1. Implementing socket options for AIX 
>> 2. DontFragmentTest failure 
>> 
>> - Implementing socket options for AIX :
>> 
>> Unlike the linux, windows and macOS, AIX uses the default implementation for socket options such as ipDontFragmentSupported(), keepAliveOptionsSupported(), setTcpkeepAliveProbes, getTcpkeepAliveProbes, setQuickAck, getQuickAck and more, where it either returns false or exception. These options can be implemented on AIX with the supported flags like SO_PEERID, TCP_NODELAYACK is the equivalent AIX option for TCP_QUICKACK and IPPROTO_TCP, IP_DONTFRAG. 
>> 
>> - DontFragment test failure :
>> 
>> DontFragmentTest.java fails with a runtime exception : “IP_DONTFRAGMENT should be supported” because the supportOptions doesn’t contain IP_DONTFRAGMENT flag.
>> 
>> Reported Issue :  [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089)
>
> Varada M has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update to copyright year

Hello Varada, overall the changes look OK to me. I missed it previously, but the `jdk/net/ExtendedSocketOptions.java` file will need an update to the copyright year.

Before integrating, please wait for another review from someone more experienced in this area. I lack experience in the native/C area, so I would like another Reviewer to take a look at this.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13240#pullrequestreview-1370236461



More information about the build-dev mailing list