RFR: 8304434: [AIX] Update minimum xlclang version [v2]
Erik Joelsson
erikj at openjdk.org
Fri Apr 21 12:44:56 UTC 2023
On Fri, 21 Apr 2023 11:54:04 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> seems I have to adjust the separated test script to
>
> ```
> #!/bin/sh
>
> COMPILER_VERSION_OUTPUT=`xlclang -qversion 2>&1`
>
> COMPILER_VERSION_NUMBER=`echo $COMPILER_VERSION_OUTPUT | sed -e 's/^.*Version: ([1-9][0-9.]*).*$/\1/'`
>
> echo $COMPILER_VERSION_OUTPUT
> echo $COMPILER_VERSION_NUMBER
> ```
>
> then it works nicely. The bash version check above from our configure however really fails but this is a separated issue.
>
> So I think it is fine, reviewed !
Yes, the `@<:@` constructs are one way to get `[` into a string in m4. Not very readable. Another solution is to encase the whole expression in `[...]`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13086#issuecomment-1517779243
More information about the build-dev
mailing list