RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

Chen Liang liach at openjdk.org
Thu Apr 20 02:39:46 UTC 2023


This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. The root cause might be that JMH requires passing VM args to benchmarks in quotes, which might have triggered incorrect detections in `FIXPATH` (as in comparison, `$1_MICRO_JAVA_OPTIONS += --add-opens=java.base/java.io=ALL-UNNAMED` right above this patch seems to work fine)
Also removed a useless and wrong Java flag to the java running javac, originally intended to enable running `make test TEST="loom.obsolete"` benchmarks.

Since I only have a windows cygwin environment, I am not quite sure if this works elsewhere.

-------------

Commit messages:
 - 8305669: RuntimeException when running benchmarks through make on Windows/WSL

Changes: https://git.openjdk.org/jdk/pull/13550/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13550&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8305669
  Stats: 7 lines in 2 files changed: 1 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/13550.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13550/head:pull/13550

PR: https://git.openjdk.org/jdk/pull/13550



More information about the build-dev mailing list