RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL

[Jorn Vernee]

On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang <liach at openjdk.org> wrote:

> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. The root cause might be that JMH requires passing VM args to benchmarks in quotes, which might have triggered incorrect detections in `FIXPATH` (as in comparison, `$1_MICRO_JAVA_OPTIONS += --add-opens=java.base/java.io=ALL-UNNAMED` right above this patch seems to work fine)
> Also removed a useless and wrong Java flag to the java running javac, originally intended to enable running `make test TEST="loom.obsolete"` benchmarks.
> 
> Since I only have a windows cygwin environment, I am not quite sure if this works elsewhere.

This patch is not working for me on WSL. It results in:


/mnt/h/openjdk/git-jdk2/build/windows-release/images/jdk/bin/java


The command is missing a trailing `.exe`, which is needed on WSL. I think `FIXPATH` on the entire invocation takes care of this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13550#issuecomment-1516559182