RFR: 8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR [v2]

Erik Joelsson erikj at openjdk.org
Wed Aug 9 14:03:58 UTC 2023


On Wed, 9 Aug 2023 12:33:45 GMT, Jesse Glick <duke at openjdk.org> wrote:

>> doc/building.md line 2035:
>> 
>>> 2033: you to follow our rules and guidelines to be able to accept your contribution.
>>> 2034: 
>>> 2035: The official place to start is the [OpenJDK Developers’ Guide](https://openjdk.org/guide/).
>> 
>> When changing this file, you also need to regenerate the `building.html`. See bottom of this file for instructions.
>
> See https://github.com/openjdk/jdk/pull/14716#discussion_r1288389758. I am supposed to check in just the modified HTML paragraph? All the modifications to `building.html`, even those unrelated to the Markdown change? All the modifications to other HTML files, even those unrelated to this patch?

Different versions of pandoc will create different output. The version we currently use is defined in `make/devkit/createPandocBundle.sh`. If you are unable to use this version, I can generate the file for you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14716#discussion_r1288504972



More information about the build-dev mailing list