RFR: 8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR [v2]
Erik Joelsson
erikj at openjdk.org
Wed Aug 9 14:03:59 UTC 2023
On Wed, 9 Aug 2023 13:42:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> See https://github.com/openjdk/jdk/pull/14716#discussion_r1288389758. I am supposed to check in just the modified HTML paragraph? All the modifications to `building.html`, even those unrelated to the Markdown change? All the modifications to other HTML files, even those unrelated to this patch?
>
> Different versions of pandoc will create different output. The version we currently use is defined in `make/devkit/createPandocBundle.sh`. If you are unable to use this version, I can generate the file for you.
I did just that, here is my commit: https://github.com/erikj79/jdk/commits/JDK-8312882-contributing. Feel free to just pull it in.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14716#discussion_r1288517931
More information about the build-dev
mailing list