RFR: 8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR [v4]
Jesper Wilhelmsson
jwilhelm at openjdk.org
Wed Aug 9 16:09:58 UTC 2023
On Wed, 9 Aug 2023 14:39:05 GMT, Jesse Glick <duke at openjdk.org> wrote:
>> @jaikiran in https://github.com/openjdk/jdk/pull/12871#issuecomment-1612310113 pointed me to a resource I had not previously found. https://openjdk.org/contribute is fine at a high level but still says things like
>>
>>> When your change is ready, send a message to the appropriate development list…
>>
>> which clearly predates Skara, and does not apparently link to anything more current. Whereas this https://github.com/openjdk/jdk/blob/master/doc/building.md is thorough and discoverable, finding accurate guidelines for proposing pull requests was tough.
>
> Jesse Glick has updated the pull request incrementally with one additional commit since the last revision:
>
> Regnerated building.html with preferred pandoc version
>
> (cherry picked from commit 4e418ebfc0d80ba228760c5f6f5332470f3875ce)
Looks good to me. I would prefer if another reviewer approves this change as well even though the bots might accept that only one reviewer approved.
-------------
Marked as reviewed by jwilhelm (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14716#pullrequestreview-1569942228
More information about the build-dev
mailing list