RFR: 8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR [v5]
Jesse Glick
duke at openjdk.org
Wed Aug 9 16:27:38 UTC 2023
> @jaikiran in https://github.com/openjdk/jdk/pull/12871#issuecomment-1612310113 pointed me to a resource I had not previously found. https://openjdk.org/contribute is fine at a high level but still says things like
>
>> When your change is ready, send a message to the appropriate development list…
>
> which clearly predates Skara, and does not apparently link to anything more current. Whereas this https://github.com/openjdk/jdk/blob/master/doc/building.md is thorough and discoverable, finding accurate guidelines for proposing pull requests was tough.
Jesse Glick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
- Merge branch 'master' of https://github.com/openjdk/jdk into patch-1
- Regnerated building.html with preferred pandoc version
(cherry picked from commit 4e418ebfc0d80ba228760c5f6f5332470f3875ce)
- Hand-picked HTML diff since `make update-build-docs` rewrote everything https://github.com/openjdk/jdk/pull/14716#discussion_r1288412572
- Keep it simple https://github.com/openjdk/jdk/pull/14716#discussion_r1288391918
- Making `building.md` also link only to the guide
- Linking only to the guide, as suggested by @JesperIRL: https://github.com/openjdk/jdk/pull/14716#issuecomment-1670908305
- Merge branch 'master' of https://github.com/openjdk/jdk into patch-1
- 8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14716/files
- new: https://git.openjdk.org/jdk/pull/14716/files/d5e3dccf..f85f4e67
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14716&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14716&range=03-04
Stats: 1148 lines in 103 files changed: 189 ins; 554 del; 405 mod
Patch: https://git.openjdk.org/jdk/pull/14716.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14716/head:pull/14716
PR: https://git.openjdk.org/jdk/pull/14716
More information about the build-dev
mailing list