RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v4]
Dean Long
dlong at openjdk.org
Wed Aug 16 21:37:36 UTC 2023
On Wed, 16 Aug 2023 19:16:28 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion warnings in runtime code. This is the last one I'm going to do for runtime for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove wrong comment.
src/hotspot/share/utilities/elfFile.hpp line 790:
> 788: // The address and op_index registers, taken together, form an operation pointer that can reference any
> 789: // individual operation with the instruction stream. This field was introduced with DWARF 4.
> 790: uint64_t _op_index;
This can be uint8_t, because it can never be larger than _maximum_operations_per_instruction, which is also a byte.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296452122
More information about the build-dev
mailing list