RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v4]

Dean Long dlong at openjdk.org
Wed Aug 16 21:41:34 UTC 2023


On Wed, 16 Aug 2023 19:16:28 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion warnings in runtime code.  This is the last one I'm going to do for runtime for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove wrong comment.

src/hotspot/share/utilities/elfFile.cpp line 1723:

> 1721: void DwarfFile::LineNumberProgram::LineNumberProgramState::set_index_register(const uint64_t operation_advance,
> 1722:                                                                               const LineNumberProgramHeader& header) {
> 1723:   _op_index = (_op_index + operation_advance) % header._maximum_operations_per_instruction;

This should be narrowed by a byte.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296456394


More information about the build-dev mailing list