[Proposal] Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll

Frederic Thevenet fthevene at redhat.com
Tue Dec 5 14:19:16 UTC 2023


Hi Magnus,


On 05/12/2023 13:58, Magnus Ihse Bursie wrote:
>
> So this is really a "--with-jdk-rc-vendor-name", since it will use 
> that value instead of --with-jdk-vendor-name for the RC fields in 
> Windows binaries?
>
I don't have a strong opinion about the name, only the target RC field 
in question is called "CompanyName", and this new option would only be 
used to set this property, so referencing to this instead of the term 
"vendor" made maybe more sense to me.

> Would --with-jdk-vendor-name be used for anything at all on Windows in 
> that case?
>

I can't find any references to an existing "--with-jdk-vendor-name" so I 
assume than you meant "--wtih-vendor-name", is that correct?

If so, yes; "--with-vendor-name" would still be used for the same things 
than it currently is, with the exception of populating the "CompanyName" 
RC field *if* "--with-jdk-rc-vendor/company-name" is also used.

-- 
Frederic Thevenet
Senior Software Engineer - OpenJDK
Red Hat France<https://www.redhat.com>
BAF5 C2D2 0BE0 1715 5EE1 0815 2065 AD47 B326 EB92
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20231205/b1a0396d/attachment.htm>


More information about the build-dev mailing list