RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

Rich DiCroce duke at openjdk.org
Mon Feb 27 15:35:33 UTC 2023


On Mon, 27 Feb 2023 15:25:16 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Rich DiCroce has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Forgot to add file
>>  - Resolve review comments
>
> src/java.base/windows/native/libnet/NetworkInterface.h line 39:
> 
>> 37:     struct _netaddr *Next;
>> 38: } netaddr;
>> 39: 
> 
> Can NetworkInterface.h be dropped, and netaddr moved to NetworkInterface.c?

I did that in an earlier revision. Then @msheppar asked for it to be moved back. See https://github.com/openjdk/jdk/pull/12593#issuecomment-1434450339

-------------

PR: https://git.openjdk.org/jdk/pull/12593



More information about the build-dev mailing list