RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

Alan Bateman alanb at openjdk.org
Tue Feb 28 16:36:04 UTC 2023


On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce <duke at openjdk.org> wrote:

>> Improves performance and correctness, as discussed on the net-dev mailing list.
>
> Rich DiCroce has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Forgot to add file
>  - Resolve review comments

src/java.base/windows/native/libnet/NetworkInterface.c line 144:

> 142:                         uniAddrs->Table[i].DadState == IpDadStateDeprecated)) {
> 143:             addrCount++;
> 144:             addrsCurrent = malloc(sizeof(netaddr));

Can you do a pass over this to handle the case where malloc fails?

-------------

PR: https://git.openjdk.org/jdk/pull/12593



More information about the build-dev mailing list