RFR: 8294982: Implementation of Classfile API [v20]

Adam Sotona asotona at openjdk.org
Tue Feb 28 14:37:47 UTC 2023


On Thu, 16 Feb 2023 13:47:04 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java line 38:
> 
>> 36:     private final List<Attribute<?>> attributes = new ArrayList<>();
>> 37: 
>> 38:     public AttributeHolder() {
> 
> default constructor

yes, it is a default constructor, do you suggest to remove it?

-------------

PR: https://git.openjdk.org/jdk/pull/10982



More information about the build-dev mailing list