RFR: 8294982: Implementation of Classfile API [v20]

[Maurizio Cimadamore]

On Tue, 28 Feb 2023 14:33:58 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java line 38:
>> 
>>> 36:     private final List<Attribute<?>> attributes = new ArrayList<>();
>>> 37: 
>>> 38:     public AttributeHolder() {
>> 
>> default constructor
>
> yes, it is a default constructor, do you suggest to remove it?

Yes, it's inside the implementation, it's not like it's used as a placeholder for javadoc or anything?

-------------

PR: https://git.openjdk.org/jdk/pull/10982