RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

Alan Bateman alanb at openjdk.org
Tue Feb 28 18:00:17 UTC 2023


On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce <duke at openjdk.org> wrote:

>> Improves performance and correctness, as discussed on the net-dev mailing list.
>
> Rich DiCroce has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Forgot to add file
>  - Resolve review comments

src/java.base/windows/native/libnet/NetworkInterface.c line 646:

> 644:     since multicast is unlikely to be disabled,
> 645:     and a boolean can't represent the full range of possibilities anyway.
> 646:     */

I don't think it's useful to include the historical note. Instead, I think reduce this down to a line or two to say that it optimistically assumes multicast is enabled.

-------------

PR: https://git.openjdk.org/jdk/pull/12593



More information about the build-dev mailing list