jpackageapplauncher linker arguments for osx

[David Holmes]

On 8/01/2023 8:39 pm, David Schumann wrote:
> Hello,
> 
> I'm not 100% sure if this list is the correct one for this topic, feel 
> free to redirect me.

core-libs-dev - cc'd

Cheers,
David

> Currently the jpackageapplauncher binary gets linked without the 
> "-headerpad_max_install_names" argument on osx. This prevents a user 
> from using the install_name_tool with the launcher binary.
> This means that it's currently not possible to include dylibs in the 
> application bundle.
> 
> To provide a bit more context:
> I'm using jpackage to build an app bundle. The java application itself 
> uses external native libraries, which internally use dlopen to reference 
> other libs. Normaly one would include the other libs in the app bundle, 
> and use the install_name_tool to tell the dynamic linker which paths to 
> load the libraries from. However since the launcher binary doesn't get 
> linked with the correct arguments, this isn't possible.
> 
> I wanted to discuss this change, and it it makes sense for me to open a 
> pull request for it.
> The change would be in 
> https://github.com/openjdk/jdk/blob/master/make/modules/jdk.jpackage/Lib.gmk#L76 <https://github.com/openjdk/jdk/blob/master/make/modules/jdk.jpackage/Lib.gmk#L76>
> 
> Best Regards,
> David Schumann
>