RFR: JDK-8298908: Instrument Metaspace for ASan [v7]
Justin King
jcking at openjdk.org
Mon Jan 9 15:57:53 UTC 2023
> This change instruments Metaspace for ASan. Metaspace allocates memory using `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports applications [manually poisoning/unpoisoning memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning). ASan is able to detect poisoned memory, similar to `use-after-free`, and will raise an error similarly called `use-after-poison`. This provides and extra layer of defense and confidence.
>
> The header `sanitizers/address.h` defines macros for poisoning/unpoisoning memory regions. These macros can be used regardless of build mode. When ASan is not available, they are implemented using a NOOP approach which still compiles the arguments but does so such that they will be stripped out by the compiler due to being unreachable. This helps with maintenance.
>
> This also has the added benefit of making [LSan](https://bugs.openjdk.org/browse/JDK-8298445) more accurate and deterministic, as LSan will not look for pointers to malloc memory in poisoned memory regions.
>
> IMO the benefit of doing this greatly outweighs the cost.
Justin King has updated the pull request incrementally with one additional commit since the last revision:
Address review feedback
Signed-off-by: Justin King <jcking at google.com>
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11702/files
- new: https://git.openjdk.org/jdk/pull/11702/files/00cf2efc..5ec30c8e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11702&range=06
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11702&range=05-06
Stats: 12 lines in 3 files changed: 4 ins; 5 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/11702.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11702/head:pull/11702
PR: https://git.openjdk.org/jdk/pull/11702
More information about the build-dev
mailing list