RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v10]

Julian Waters jwaters at openjdk.org
Thu Jan 12 14:10:23 UTC 2023


On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> MSYS2 should be more appropriately installed into the runner's tool cache rather than inside the newly checked out repository containing all the JDK's source code, as doing so may interfere with the build process and cause weird corner cases in the submitted actions workflow
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-2
>  - Install in RUNNER_TOOL_CACHE
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Formatting
>  - Directory reference
>  - Avoid installing MSYS2 in the JDK's source directory

Linking the log from another unrelated PR of mine (https://github.com/TheShermanTanker/jdk/actions/runs/3892586367/jobs/6644178546) to confirm that the tar issue isn't related to this change. Maybe we need to selectively disable some of the Git tools for this to truly work properly?

-------------

PR: https://git.openjdk.org/jdk/pull/11782



More information about the build-dev mailing list