RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v10]

[Magnus Ihse Bursie]

On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> MSYS2 should be more appropriately installed into the runner's tool cache rather than inside the newly checked out repository containing all the JDK's source code, as doing so may interfere with the build process and cause weird corner cases in the submitted actions workflow
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-2
>  - Install in RUNNER_TOOL_CACHE
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Formatting
>  - Directory reference
>  - Avoid installing MSYS2 in the JDK's source directory

Actually, hold your horses. I checked the GHA run, and there were a lot of failures on windows... `tar` did not work, and seems it tried to pick up one from the Git unix env.

windows-aarch64 / build (debug)
 Failed to save: "C:\Program failed with error: The process 'C:\Program Files\Git\usr\bin\tar.exe' failed with exit code 2
--
windows-x64 / build (release)
Failed to save: "C:\Program failed with error: The process 'C:\Program Files\Git\usr\bin\tar.exe' failed with exit code 2


etc...

-------------

Changes requested by ihse (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11782