RFR: 8299330: Minor improvements in MSYS2 Workflow handling [v10]

Thu Jan 12 14:29:00 UTC 2023

On Thu, 12 Jan 2023 14:01:57 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> > Hi, I'm back today from vacation and is trying to catch up, so your timing was excellent. ;)
> 
> Haha, Merry Christmas and a Happy New Year, hope you had a good time with your family :)

Actually, I spent most of the time isolated getting a too intimate time with the SARS-CoV-2 virus. :-( Worst holiday ever, would rate 1/5. (And this was despite triple vaccines...) 

> It depends, if we are using a GitHub hosted runner (which I am very confident we are) the tool cache would be more appropriate for dumping all our required utils than the source directory

Yes we are. At least the normal OpenJDK GHA system. I assume someone could pay Github and setup personally hosted runners, in theory.

> Linking the log from another unrelated PR of mine (https://github.com/TheShermanTanker/jdk/actions/runs/3892586367/jobs/6644178546) to confirm that the tar issue isn't related to this change.

That's good news. I approved this PR now.

> Maybe we need to selectively disable some of the Git tools for this to truly work properly?

If that is a separate issue, that happens intermittently, I don't even know how to address it. Strange that it happened on multiple separate machines at the same time, even though it seems to be a runner-local problem. But in any case it is a separate issue from this.

-------------

PR: https://git.openjdk.org/jdk/pull/11782