RFR: JDK-8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC

Magnus Ihse Bursie ihse at openjdk.org
Thu Jan 12 19:01:17 UTC 2023


On Thu, 12 Jan 2023 18:30:12 GMT, Justin King <jcking at openjdk.org> wrote:

> Fix misconfigured UBSan build by funneling `UBSAN_CFLAGS` and `UBSAN_LDFLAGS` to ADLC.

Marked as reviewed by ihse (Reviewer).

Yeah. the ADLC build is still quite strange and do not conform to the rest of the build system. It's been that for quite some time and it just never has been fixed. :(

make/autoconf/jdk-options.m4 line 480:

> 478:         LDFLAGS_JDKEXE="$LDFLAGS_JDKEXE $UBSAN_LDFLAGS"
> 479:       ])
> 480:   if test "x$UBSAN_ENABLED" = xfalse; then

You don't have to explicitly declare variables empty; I don't think we normally do that.

-------------

PR: https://git.openjdk.org/jdk/pull/11975



More information about the build-dev mailing list