RFR: JDK-8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC
Justin King
jcking at openjdk.org
Thu Jan 12 19:01:19 UTC 2023
On Thu, 12 Jan 2023 18:56:38 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Fix misconfigured UBSan build by funneling `UBSAN_CFLAGS` and `UBSAN_LDFLAGS` to ADLC.
>
> make/autoconf/jdk-options.m4 line 480:
>
>> 478: LDFLAGS_JDKEXE="$LDFLAGS_JDKEXE $UBSAN_LDFLAGS"
>> 479: ])
>> 480: if test "x$UBSAN_ENABLED" = xfalse; then
>
> You don't have to explicitly declare variables empty; I don't think we normally do that.
Mostly me being pedantic to prevent someone from accidentally referencing the variable without checking UBSAN_ENABLED.
-------------
PR: https://git.openjdk.org/jdk/pull/11975
More information about the build-dev
mailing list