RFR: JDK-8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC
Magnus Ihse Bursie
ihse at openjdk.org
Fri Jan 13 14:04:24 UTC 2023
On Thu, 12 Jan 2023 18:57:41 GMT, Justin King <jcking at openjdk.org> wrote:
>> make/autoconf/jdk-options.m4 line 480:
>>
>>> 478: LDFLAGS_JDKEXE="$LDFLAGS_JDKEXE $UBSAN_LDFLAGS"
>>> 479: ])
>>> 480: if test "x$UBSAN_ENABLED" = xfalse; then
>>
>> You don't have to explicitly declare variables empty; I don't think we normally do that.
>
> Mostly me being pedantic to prevent someone from accidentally referencing the variable without checking UBSAN_ENABLED.
That would not matter anyway, they will be defined as empty strings in spec.gmk regardless. Oh well.
-------------
PR: https://git.openjdk.org/jdk/pull/11975
More information about the build-dev
mailing list