RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher
Alexander Matveev
almatvee at openjdk.org
Fri Jan 13 22:39:10 UTC 2023
On Fri, 13 Jan 2023 13:34:08 GMT, David <duke at openjdk.org> wrote:
>> This patch adds the `-headerpad_max_install_names` linker argument to the build of the `jpackageapplauncher` binary (osx only)
>>
>> Adding this argument allows the user to use the `install_name_tool` to add search paths for the dynamic linker to the launcher binary. This is required for certain use cases where a native library loads other dynamic native libraries via `dlopen`.
>>
>> The change has been successfully tested on osx on aarch64:
>>
>> make jdk.jpackage
>> install_name_tool -add_rpath @executable_path/../Frameworks/ jpackageapplauncher
>> otool -l jpackageapplauncher
>>
>> Load command 19
>> cmd LC_RPATH
>> cmdsize 48
>> path @executable_path/../Frameworks/ (offset 12)
>
>> Hi David, Thank you for your contribution!
>>
>> I updated the title of the JBS bug issue to match this PR (matching titles is a requirement, and the PR had a more descriptive title).
>>
>> The change itself look sane to me, but I'd like for @alexeysemenyukoracle to have a look at it as well.
>>
>> Also, if you ever is going to want to contribute addition PRs to OpenJDK, please see [the bot's advice above](https://github.com/openjdk/jdk/pull/11922#issuecomment-1377005320). Otherwise you are entering a world of pain.
>>
>> /reviewers 2
>
> Thanks for your feedback!
> Will do, overlooked that part in the contribution guide
@davidgiga1993 Do you have JBS account, so https://bugs.openjdk.org/browse/JDK-8300111 can be assign to you?
-------------
PR: https://git.openjdk.org/jdk/pull/11922
More information about the build-dev
mailing list