RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher

David duke at openjdk.org
Sat Jan 14 12:26:09 UTC 2023


On Fri, 13 Jan 2023 22:36:24 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>>> Hi David, Thank you for your contribution!
>>> 
>>> I updated the title of the JBS bug issue to match this PR (matching titles is a requirement, and the PR had a more descriptive title).
>>> 
>>> The change itself look sane to me, but I'd like for @alexeysemenyukoracle to have a look at it as well.
>>> 
>>> Also, if you ever is going to want to contribute addition PRs to OpenJDK, please see [the bot's advice above](https://github.com/openjdk/jdk/pull/11922#issuecomment-1377005320). Otherwise you are entering a world of pain.
>>> 
>>> /reviewers 2
>> 
>> Thanks for your feedback!
>> Will do, overlooked that part in the contribution guide
>
> @davidgiga1993 Do you have JBS account, so https://bugs.openjdk.org/browse/JDK-8300111 can be assign to you?

@sashamatveev No since this is my first contribution (I assume) the account creation/password reset doesn't work. Thus I don't have one :)

-------------

PR: https://git.openjdk.org/jdk/pull/11922



More information about the build-dev mailing list