RFR: 8294982: Implementation of Classfile API [v49]

[Adam Sotona]

On Tue, 7 Mar 2023 11:14:17 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   snippets and tests synced with jdk.jfr class instrumentation source code
>
> src/java.base/share/classes/jdk/internal/classfile/components/CodeRelabeler.java line 44:
> 
>> 42: 
>> 43: /**
>> 44:  * CodeRelabeler is a {@link jdk.internal.classfile.CodeTransform} replacing all occurrences
> 
> Nit - perhaps just use `A code relabeler is a ...` (instead of using the class name, which then would require another `{@code ... }`.

fixed, thanks.

> src/java.base/share/classes/jdk/internal/classfile/components/package-info.java line 114:
> 
>> 112:  * {@snippet lang="java" class="PackageSnippets" region="classInstrumentation"}
>> 113:  */
>> 114: package jdk.internal.classfile.components;
> 
> watch out for newline

I'm not quite sure I understand what is wrong with this javadoc fragment.
Thanks.

> src/java.base/share/classes/jdk/internal/classfile/impl/EntryMap.java line 194:
> 
>> 192:         return (int)s;
>> 193:     }
>> 194: }
> 
> newline!

Here I'm also not sure I understand, the long line has bee wrapped.

> src/java.base/share/classes/jdk/internal/classfile/impl/TargetInfoImpl.java line 34:
> 
>> 32: 
>> 33: /**
>> 34:  * TargetInfoImpl
> 
> Does this javadoc add any value? Since this is implementation, we could also remove it.

This is common practise across the whole implementation. Do you suggest to remove all similar javadoc from all implementation classes?

-------------

PR: https://git.openjdk.org/jdk/pull/10982