RFR: 8294982: Implementation of Classfile API [v49]

[Maurizio Cimadamore]

On Tue, 7 Mar 2023 14:48:43 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/classfile/impl/EntryMap.java line 194:
>> 
>>> 192:         return (int)s;
>>> 193:     }
>>> 194: }
>> 
>> newline!
>
> Here I'm also not sure I understand, the long line has bee wrapped.

I mean here (and in the other) there seems to be a missing newline at the end of the file

>> src/java.base/share/classes/jdk/internal/classfile/impl/TargetInfoImpl.java line 34:
>> 
>>> 32: 
>>> 33: /**
>>> 34:  * TargetInfoImpl
>> 
>> Does this javadoc add any value? Since this is implementation, we could also remove it.
>
> This is common practise across the whole implementation. Do you suggest to remove all similar javadoc from all implementation classes?

Well, if the javadoc simply states the name of the class it doesn't seem very useful. But I leave that decision to you.

-------------

PR: https://git.openjdk.org/jdk/pull/10982