RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v8]

Per Minborg pminborg at openjdk.org
Tue Mar 28 10:15:19 UTC 2023


On Fri, 24 Mar 2023 08:42:37 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve javadocs for Linker::captureStateLayout
>
> src/java.base/share/classes/jdk/internal/foreign/abi/fallback/LibFallback.java line 61:
> 
>> 59:     static final MemorySegment VOID_TYPE = MemorySegment.ofAddress(ffi_type_void());
>> 60:     static final short STRUCT_TAG = ffi_type_struct();
>> 61:     private static final long SIZEOF_CIF = sizeofCif();
> 
> Won’t calling `ffi_default_abi()` (and the other `ffi_*()` methods) throw `UnsatisfiedLinkError` if `SUPPORTED` is `false`?

I think so too. How do we guard agains this @JornVernee ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1150350299



More information about the build-dev mailing list