RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v8]

[Jorn Vernee]

On Tue, 28 Mar 2023 10:07:12 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/foreign/abi/fallback/LibFallback.java line 61:
>> 
>>> 59:     static final MemorySegment VOID_TYPE = MemorySegment.ofAddress(ffi_type_void());
>>> 60:     static final short STRUCT_TAG = ffi_type_struct();
>>> 61:     private static final long SIZEOF_CIF = sizeofCif();
>> 
>> Won’t calling `ffi_default_abi()` (and the other `ffi_*()` methods) throw `UnsatisfiedLinkError` if `SUPPORTED` is `false`?
>
> I think so too. How do we guard agains this @JornVernee ?

You're right. Fix here: https://github.com/minborg/jdk/pull/1

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1150645955