RFR: 8305089: [AIX] Implement missing socket options on AIX

Jaikiran Pai jpai at openjdk.org
Thu Mar 30 11:58:17 UTC 2023


On Thu, 30 Mar 2023 06:39:57 GMT, Varada M <duke at openjdk.org> wrote:

> Breaking this into two parts : 
> 
> 1. Implementing socket options for AIX 
> 2. DontFragmentTest failure 
> 
> - Implementing socket options for AIX :
> 
> Unlike the linux, windows and macOS, AIX uses the default implementation for socket options such as ipDontFragmentSupported(), keepAliveOptionsSupported(), setTcpkeepAliveProbes, getTcpkeepAliveProbes, setQuickAck, getQuickAck and more, where it either returns false or exception. These options can be implemented on AIX with the supported flags like SO_PEERID, TCP_NODELAYACK is the equivalent AIX option for TCP_QUICKACK and IPPROTO_TCP, IP_DONTFRAG. 
> 
> - DontFragment test failure :
> 
> DontFragmentTest.java fails with a runtime exception : “IP_DONTFRAGMENT should be supported” because the supportOptions doesn’t contain IP_DONTFRAGMENT flag.
> 
> Reported Issue :  [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089)

src/jdk.net/aix/classes/jdk/net/AIXSocketOptions.java line 38:

> 36: class AIXSocketOptions extends PlatformSocketOptions {
> 37: 
> 38:     public AIXSocketOptions() {

It would be good to make this package private constructor instead of `public`, but I see that the current existing `LinuxSocketOptions` class too uses `public`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13240#discussion_r1153148017



More information about the build-dev mailing list