RFR: 8305089: [AIX] Implement missing socket options on AIX [v2]

Varada M duke at openjdk.org
Thu Mar 30 16:45:35 UTC 2023


On Thu, 30 Mar 2023 11:55:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update to copyright year
>
> src/jdk.net/aix/classes/jdk/net/AIXSocketOptions.java line 38:
> 
>> 36: class AIXSocketOptions extends PlatformSocketOptions {
>> 37: 
>> 38:     public AIXSocketOptions() {
> 
> It would be good to make this package private constructor instead of `public`, but I see that the current existing `LinuxSocketOptions` class too uses `public`.

`newInstance("jdk.net.AIXSocketOptions")` will try to invoke the default constructor  `AIXSocketOptions() {}`. When we make it as private constructor PlatformSocketOptions instance will try to find jdk.net.AIXSocketOptions and within the time span it won't be able to find hence throws error (`Cannot get VM for test: java.net.SocketTimeoutException: Accept timed out`)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13240#discussion_r1153523337



More information about the build-dev mailing list