RFR: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v7]
Severin Gehwolf
sgehwolf at openjdk.org
Mon May 8 08:52:27 UTC 2023
On Fri, 5 May 2023 16:52:22 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> This PR is branched from the makefile changes for https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle containing hotspot libjvm.a and JDK static libraries
>>
>> - For libjvm.a specifically, exclude operator_new.o
>>
>> - Filter out "external" .o files (those are the .o files included from a different JDK library and needed when creating the .so shared library only) from JDK .a libraries; That's to avoid linker failures caused by duplicate symbols
>> - For libjli.a: Not include inflate.o inftrees.o inffast.o zadler32.o zcrc32.o zutil.o (compiled from zlib sources) if zlib is built as JDK bundled
>> - For libawt_xawt.a and libawt_head.a: Not include systemScale.o, since it's provided in libawt.a
>>
>> - Handle long arguments case for static build in make/common/NativeCompilation.gmk
>>
>> - Address @erikj79's comment in https://github.com/openjdk/jdk/pull/13709#discussion_r1180750185 for LIBJLI_STATIC_EXCLUDE_OBJS
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix whitespace error in make/StaticJvmLibsImage.gmk.
Seems fine to me, but I'm not an expert in on the build files. Thanks for the implementing the suggestion.
-------------
Marked as reviewed by sgehwolf (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13768#pullrequestreview-1416396939
More information about the build-dev
mailing list