RFR: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v8]

Jiangli Zhou jiangli at openjdk.org
Tue May 9 21:34:43 UTC 2023


> This PR is branched from the makefile changes for https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for handling the JDK/hotspot static libraries:
> 
> - Introduce new make target(s) for creating image/bundle containing hotspot libjvm.a and JDK static libraries
> 
> - For libjvm.a specifically, exclude operator_new.o
> 
> - Filter out "external" .o files (those are the .o files included from a different JDK library and needed when creating the .so shared library only) from JDK .a libraries; That's to avoid linker failures caused by duplicate symbols
>   - For libjli.a: Not include inflate.o inftrees.o inffast.o zadler32.o zcrc32.o zutil.o (compiled from zlib sources) if zlib is built as JDK bundled
>  - For libawt_xawt.a and libawt_head.a: Not include systemScale.o, since it's provided in libawt.a
>  
> - Handle long arguments case for static build in make/common/NativeCompilation.gmk
> 
> - Address @erikj79's comment in https://github.com/openjdk/jdk/pull/13709#discussion_r1180750185 for LIBJLI_STATIC_EXCLUDE_OBJS

Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:

  Reflect on @erikj79 suggestions/input on static-libs-image/graal-builder-image and supporting libjvm.a for different JVM_VARIANTS:
  
  - Remove the new java-static-libs and java-static-libs-bundles targets. Delete the new make/StaticJvmLibsImage.gmk.
  
  - Restore HOTSPOT_VARIANT_STATIC_LIBS_TARGETS and related definitions from previous revision for different $(JVM_VARIANTS).
  - Change the existing static-libs-image target to build libjvm.a in addition to JDK static libraries. The libjvm.a is placed under images/static-libs/lib/<JVM_VARIANTS>. When building multiple JVM variants, each variant contains its own libjvm.a under images/static-libs/lib/<variant> directory.
  
  - Add a new static-libs-graal-image target, which is used by graal-builder-image. Hotspot libjvm.a is not created when building static-libs-graal-image and graal-builder-image targets.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13768/files
  - new: https://git.openjdk.org/jdk/pull/13768/files/2cb786ab..cf317d36

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13768&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13768&range=06-07

  Stats: 107 lines in 5 files changed: 32 ins; 60 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/13768.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13768/head:pull/13768

PR: https://git.openjdk.org/jdk/pull/13768



More information about the build-dev mailing list