RFR: 8320942: Only set openjdk-target when cross compiling linux-aarch64
Magnus Ihse Bursie
ihse at openjdk.org
Wed Nov 29 07:16:02 UTC 2023
On Wed, 29 Nov 2023 02:25:20 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
> When building linux-aarch64 at Oracle using jib, --openjdk-target=aarch64-linux-gnu is always specified regardless of if building natively or cross compiling (on linux-x64). Among other things this has the (harmless) effect of tricking configure into thinking that it's cross compiling even for native builds:
>
> checking whether we are cross compiling... yes
>
> The reason is that the target value (aarch64-linux-gnu) doesn't match what config.guess returns (aarch64-unknown-linux-gnu). An explicit target is only needed when cross compiling and should not be specified for native builds.
LGTM
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16873#pullrequestreview-1754583681
More information about the build-dev
mailing list