RFR: 8320942: Only set openjdk-target when cross compiling linux-aarch64

[Andrew Haley]

On Wed, 29 Nov 2023 02:25:20 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

> When building linux-aarch64 at Oracle using jib, --openjdk-target=aarch64-linux-gnu is always specified regardless of if building natively or cross compiling (on linux-x64). Among other things this has the (harmless) effect of tricking configure into thinking that it's cross compiling even for native builds:
> 
> checking whether we are cross compiling... yes
> 
> The reason is that the target value (aarch64-linux-gnu) doesn't match what config.guess returns (aarch64-unknown-linux-gnu). An explicit target is only needed when cross compiling and should not be specified for native builds.

I'm not objecting to this patch, which is fine as it goes, but I think that the real test for cross compiling isn't a different build and target platform, but a different build and target sysroot. You're often building for EL 9 on an EL 8 machine, and that really does need to be treated as cross compilation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16873#issuecomment-1831441045