RFR: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Fri Oct 20 13:49:37 UTC 2023
On Wed, 11 Oct 2023 10:00:14 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:
>> Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added a test to verify that symbols are available
>
> Indeed, I see no reason to rush the integration for this before we've resolved the failing test.
>
> I can confirm that outside of the context of GHA, the `test-prebuilt` target does not properly resolve _relative_ paths that are passed to SYMBOLS_IMAGE_DIR, but works fine with absolute path.
> This is therefore likely *not* the reason for the test failing in GHA, since this uses absolute paths (i.e. `/d/a/jdk/jdk/bundles/symbols/jdk-22/fastdebug`).
> This is still annoying, as the other paths used as parameters by the same `test-prebuilt` do accept related paths, but beside the point here, so I'll leave it at that for now and maybe come back to it in separately.
>
> Meanwhile, I have instrumented the GHA test workflow as @magicus suggested and waiting for the results.
@fthevenet Did the instrumentation give anything?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16039#issuecomment-1772771604
More information about the build-dev
mailing list